parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
573 stars 188 forks source link

fix: Malformed JSON in `whereMatchesQuery` #955

Closed juriSacchetta closed 1 year ago

juriSacchetta commented 1 year ago

Pull Request

Issue

Re-open PR: #943 Closes: #939

Approach

Fix bug in JSON creation when whereMatchesQuery is used.

Tasks

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

parse-github-assistant[bot] commented 1 year ago

I will reformat the title to use the proper commit message syntax.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (c9d64cb) 39.31% compared to head (6f31021) 39.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #955 +/- ## ========================================== + Coverage 39.31% 39.33% +0.01% ========================================== Files 60 60 Lines 3355 3356 +1 ========================================== + Hits 1319 1320 +1 Misses 2036 2036 ``` | [Impacted Files](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/955?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | Coverage Δ | | |---|---|---| | [packages/dart/lib/src/network/parse\_query.dart](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/955?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-cGFja2FnZXMvZGFydC9saWIvc3JjL25ldHdvcmsvcGFyc2VfcXVlcnkuZGFydA==) | `45.28% <100.00%> (+0.20%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

juriSacchetta commented 1 year ago

Could you add a changelog entry?

I don't know how to do it, can you give me some indication?

mbfakourii commented 1 year ago

Could you add a changelog entry?

I don't know how to do it, can you give me some indication?

An example is in this PR.

It means is adding changes and bump version (increasing the package version).

juriSacchetta commented 1 year ago

Could you add a changelog entry?

I don't know how to do it, can you give me some indication?

An example is in this PR.

It means is adding changes and bump version (increasing the package version).

Thank you for your reply. Please let me know if it's alright now.

mbfakourii commented 1 year ago

Could you add a changelog entry?

I don't know how to do it, can you give me some indication?

An example is in this PR. It means is adding changes and bump version (increasing the package version).

Thank you for your reply. Please let me know if it's alright now.

Looks good