Closed mbfakourii closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
a2fb099
) 39.60% compared to head (1a68ec4
) 39.60%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good! Is this ready for merge?
Yes, it's ready
this fail tests for this bug I don't think there is a problem with merge
If we restart the CI it should work, since dio has fixed the issue and there's no lock file.
If we restart the CI it should work, since dio has fixed the issue and there's no lock file.
What is your suggestion to improve CI?
Improve the CI? What do you mean?
Improve the CI? What do you mean?
I meant here
I don't think there's anything to improve. In that comment I was referring to your comment where you said that the CI in this PR here fails because of the dio issue. Since the CI now passes without us changing the dio dependency version, we know that the issue self-resolved and that we can close https://github.com/parse-community/Parse-SDK-Flutter/pull/959 without us having to publish a release.
I don't think there's anything to improve. In that comment I was referring to your comment where you said that the CI in this PR here fails because of the dio issue. Since the CI now passes without us changing the dio dependency version, we know that the issue self-resolved and that we can close #959 without us having to publish a release.
So there is no problem. Regarding this pull request, you may check these two sections. [1] , [2]
Looks good! Is this ready to merge?
How about now?
It looks good
Pull Request
Issue
Closes: #957
Approach
Improved pubspecs files base dart site and example projects
Tasks