search

parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
573 stars 188 forks source link

refactor: Improve pubspecs files and example projects #956

Closed mbfakourii closed 1 year ago

mbfakourii commented 1 year ago

Pull Request

Issue

Closes: #957

Approach

Improved pubspecs files base dart site and example projects

Tasks

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (a2fb099) 39.60% compared to head (1a68ec4) 39.60%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #956 +/- ## ======================================= Coverage 39.60% 39.60% ======================================= Files 60 60 Lines 3333 3333 ======================================= Hits 1320 1320 Misses 2013 2013 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mbfakourii commented 1 year ago

Looks good! Is this ready for merge?

Yes, it's ready

mbfakourii commented 1 year ago

this fail tests for this bug I don't think there is a problem with merge

mtrezza commented 1 year ago

If we restart the CI it should work, since dio has fixed the issue and there's no lock file.

mbfakourii commented 1 year ago

If we restart the CI it should work, since dio has fixed the issue and there's no lock file.

What is your suggestion to improve CI?

mtrezza commented 1 year ago

Improve the CI? What do you mean?

mbfakourii commented 1 year ago

Improve the CI? What do you mean?

I meant here

mtrezza commented 1 year ago

I don't think there's anything to improve. In that comment I was referring to your comment where you said that the CI in this PR here fails because of the dio issue. Since the CI now passes without us changing the dio dependency version, we know that the issue self-resolved and that we can close https://github.com/parse-community/Parse-SDK-Flutter/pull/959 without us having to publish a release.

mbfakourii commented 1 year ago

I don't think there's anything to improve. In that comment I was referring to your comment where you said that the CI in this PR here fails because of the dio issue. Since the CI now passes without us changing the dio dependency version, we know that the issue self-resolved and that we can close #959 without us having to publish a release.

So there is no problem. Regarding this pull request, you may check these two sections. [1] , [2]

mbfakourii commented 1 year ago

Looks good! Is this ready to merge?

Tag each package with at most 5 topics

mbfakourii commented 1 year ago

How about now?

It looks good