parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
573 stars 188 forks source link

refactor: Upgrade `connectivity_plus` #974

Closed mbfakourii closed 10 months ago

mbfakourii commented 10 months ago

Pull Request

Issue

Closes: #972

Approach

Upgrade connectivity plus to 5.0.1

Tasks

parse-github-assistant[bot] commented 10 months ago

Thanks for opening this pull request!

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (9431086) 40.60% compared to head (2ea5cab) 40.60%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #974 +/- ## ======================================= Coverage 40.60% 40.60% ======================================= Files 60 60 Lines 3401 3401 ======================================= Hits 1381 1381 Misses 2020 2020 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mbfakourii commented 10 months ago

@mtrezza

Can you give me access to execute the CI file? I have to commit again to run CI! [1]

mtrezza commented 10 months ago

You can close and re-open the PR to re-run the CI. Why do you need to re-run the CI in the first place, do we have a flaky test?

mbfakourii commented 10 months ago

You can close and re-open the PR to re-run the CI. Why do you need to re-run the CI in the first place, do we have a flaky test?

In this action run, I encountered a codecov error and had to run CI again !

mbfakourii commented 10 months ago

Looks good, this is only an internal package, so no breaking change?

The CI issue looks like a temporary service issue that self-resolved.

No, there is no problem, I think it is ready for merge.

mbfakourii commented 10 months ago

If this should be released immediately then the fix PR requires a changelog entry. Otherwise you can make it a refactor to release it with the next fix or feat PR.

I think it is a refactor and there is no need for versioning.