Closed mbfakourii closed 9 months ago
I will reformat the title to use the proper commit message syntax.
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
f757dad
) 40.60% compared to head (f2d35bd
) 44.12%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could you add a test?
These additional items are in a private function, it is also for socket operation and cannot be tested.
Not sure I understand; why do you think it cannot be tested?
Not sure I understand; why do you think it cannot be tested?
Changes in this function. This function is a private function. It cannot be accessed from outside.
Is it not possible to access a private function in tests? How are all the LiveQuery features then tested?
If it not possible to access a private function in tests? How are all the LiveQuery features then tested?
There are currently no tests for LiveQuery
!
Interesting. It should be easily possible to test an internal method. Can't you just reference the internal method directly in the test file, mock channel
, execute the method and check whether the connect message has the installationId set?
Interesting. It should be easily possible to test an internal method. Can't you just reference the internal method directly in the test file, mock
channel
, execute the method and check whether the connect message has the installationId set?
I did not test with mockito
, I will try to implement
@mtrezza
Test added
Congrats for adding the first live query test!
This should be optional since, it breaks live query when using lower versions of parse server. Specially for who uses sashido.io
@maravilhosinga could you please open a new issue and provide more specifics about what's breaking?
Pull Request
Issue
Closes: #975
Approach
add
installationId
in LiveQueryconnect
.Tasks