parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
573 stars 188 forks source link

fix: Conflict with new version of `connectivity_plus` dependency #987

Closed mbfakourii closed 6 months ago

mbfakourii commented 7 months ago

Pull Request

Issue

Closes: #986

Approach

Upgrade flutter dependencies

Tasks

parse-github-assistant[bot] commented 7 months ago

Thanks for opening this pull request!

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c5f08f6) 44.12% compared to head (be994db) 44.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #987 +/- ## ========================================== + Coverage 44.12% 44.16% +0.03% ========================================== Files 60 60 Lines 3404 3401 -3 ========================================== Hits 1502 1502 + Misses 1902 1899 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mbfakourii commented 6 months ago

Looks good, is this really just a refactor (no release will be published with this PR)?

To solve issues number #986, I think it is better to release a new version.

mtrezza commented 6 months ago

To release a new version, could you please as usual increase the version in the package and change the PR title to fix if it's a bug fix?

mbfakourii commented 6 months ago

To release a new version, could you please as usual increase the version in the package and change the PR title to fix if it's a bug fix?

Done

mtrezza commented 6 months ago

Could you please review the PR title - if it's a fix it should describe the bug; if it's not a bug fix it may be a feat, for example to introduce compatibility.

mbfakourii commented 6 months ago

Could you please review the PR title - if it's a fix it should describe the bug; if it's not a bug fix it may be a feat, for example to introduce compatibility.

Changed.