search

parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
573 stars 188 forks source link

feat: Add support for Dart `3.1`, `3.2`, `3.3`; remove support for Dart `2.19` #993

Closed mbfakourii closed 4 months ago

mbfakourii commented 4 months ago

Pull Request

Issue

Closes: #992

Approach

n/a

Tasks

parse-github-assistant[bot] commented 4 months ago

Thanks for opening this pull request!

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 43.37%. Comparing base (c388545) to head (283af26). Report is 1 commits behind head on master.

:exclamation: Current head 283af26 differs from pull request most recent head 5c11e03. Consider uploading reports for the commit 5c11e03 to get more accurate results

Files Patch % Lines
packages/dart/lib/src/utils/parse_live_list.dart 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #993 +/- ## ======================================= Coverage 43.37% 43.37% ======================================= Files 61 61 Lines 3463 3463 ======================================= Hits 1502 1502 Misses 1961 1961 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mtrezza commented 4 months ago

This is a breaking change since we are removing support for older dart versions, right? Could you please rename the PR title to

feat: Add support for Dart x.x, x.x; remove support for Dart x.x, x.x

mbfakourii commented 4 months ago

This is a breaking change since we are removing support for older dart versions, right? Could you please rename the PR title to

feat: Add support for Dart x.x, x.x; remove support for Dart x.x, x.x

Yes, the title has also changed.

mtrezza commented 4 months ago

Could you add the changelog entry?

Features:
- ...

Breaking Changes:
- Removes support for Dart ...
mbfakourii commented 4 months ago

Could you add the changelog entry?

Features:
- ...

Breaking Changes:
- Removes support for Dart ...

Added.

mbfakourii commented 4 months ago

CI errors are related to codecov.