fix: Calling `Parse.Object.relation.add` multiple times adds only the first object

parse-community / Parse-SDK-JS

The JavaScript SDK for Parse Platform

https://parseplatform.org

Apache License 2.0

1.32k stars 596 forks source link

fix: Calling `Parse.Object.relation.add` multiple times adds only the first object #2078

Closed mstniy closed 7 months ago

mstniy commented 8 months ago

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Closes: #2056

Approach

ParseOp.applyTo: Take as parameter not just the className and objectId, but the whole object. This allows ObjectStateMutations.estimateAttributes to return relations with correct parents

Tasks

[x] Add tests

parse-github-assistant[bot] commented 8 months ago

I will reformat the title to use the proper commit message syntax.

parse-github-assistant[bot] commented 8 months ago

Thanks for opening this pull request!

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eff6932) 100.00% compared to head (8969f0b) 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## alpha #2078 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 61 61 Lines 6178 6173 -5 Branches 1496 1494 -2 ========================================= - Hits 6178 6173 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mstniy commented 7 months ago

Done @mtrezza .

Weird that this is how it is set up. I did not explicitly disable it.

parseplatformorg commented 7 months ago

🎉 This change has been released in version 4.3.1-alpha.2

parseplatformorg commented 6 months ago

🎉 This change has been released in version 5.0.0-beta.1

parseplatformorg commented 6 months ago

🎉 This change has been released in version 5.0.0