parse-community / Parse-SDK-JS

The JavaScript SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
1.32k stars 596 forks source link

feat: Add support for setting `Parse.ACL` from JSON #2097

Closed dplewis closed 5 months ago

dplewis commented 6 months ago

Pull Request

Issue

Setting ACL from JSON throws ACL must be Parse.ACL error. ACL should be handled the same as other special fields like id, createdAt, updatedAt

Closes: https://github.com/parse-community/Parse-SDK-JS/issues/2096, https://github.com/parse-community/Parse-SDK-JS/issues/2028

Approach

Tasks

parse-github-assistant[bot] commented 6 months ago

Thanks for opening this pull request!

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.98%. Comparing base (b0adf7e) to head (087e08b). Report is 5 commits behind head on alpha.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## alpha #2097 +/- ## ======================================= Coverage 99.98% 99.98% ======================================= Files 61 61 Lines 6184 6185 +1 Branches 1499 1499 ======================================= + Hits 6183 6184 +1 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dplewis commented 5 months ago

This isn't a breaking change.

dplewis commented 5 months ago

@mtrezza I was able to keep the original error handling while adding this new feature. This is ready for review.

dplewis commented 5 months ago

Yep

parseplatformorg commented 5 months ago

🎉 This change has been released in version 5.1.0-alpha.1

parseplatformorg commented 4 months ago

🎉 This change has been released in version 5.1.0-beta.1

parseplatformorg commented 4 months ago

🎉 This change has been released in version 5.1.0