fix: Local datastore throws error when `Parse.Query.notEqualTo` is set to `null`

parse-community / Parse-SDK-JS

The JavaScript SDK for Parse Platform

https://parseplatform.org

Apache License 2.0

1.33k stars 597 forks source link

fix: Local datastore throws error when `Parse.Query.notEqualTo` is set to `null` #2102

Closed dplewis closed 6 months ago

dplewis commented 6 months ago

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Approach

Properly handle null comparison operators

Tasks

[x] Add tests
[x] Add changes to documentation (guides, repository pages, code comments)

parse-github-assistant[bot] commented 6 months ago

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (72bc9ac) to head (1d33aba). Report is 4 commits behind head on alpha.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## alpha #2102 +/- ## =========================================== + Coverage 99.98% 100.00% +0.01% =========================================== Files 61 61 Lines 6185 6185 Branches 1499 1499 =========================================== + Hits 6184 6185 +1 + Misses 1 0 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dplewis commented 6 months ago

@mtrezza This is ready to merge

parseplatformorg commented 6 months ago

🎉 This change has been released in version 5.1.0-alpha.2

parseplatformorg commented 5 months ago

🎉 This change has been released in version 5.1.0-beta.1

parseplatformorg commented 5 months ago

🎉 This change has been released in version 5.1.0