refactor: Convert `CoreManager` to TypeScript

parse-community / Parse-SDK-JS

The JavaScript SDK for Parse Platform

https://parseplatform.org

Apache License 2.0

1.32k stars 596 forks source link

refactor: Convert `CoreManager` to TypeScript #2118

Closed dplewis closed 4 months ago

dplewis commented 4 months ago

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Documentation missing from CoreManager.

Approach

Converting CoreManager to TypeScript will lay the foundation for future conversions. CoreManager will be the key to removing circular dependencies which is main issue when converting the entire project to TypeScript.

parse-github-assistant[bot] commented 4 months ago

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (72bc9ac) to head (2665a78). Report is 20 commits behind head on alpha.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## alpha #2118 +/- ## =========================================== + Coverage 99.98% 100.00% +0.01% =========================================== Files 61 64 +3 Lines 6185 6205 +20 Branches 1499 1504 +5 =========================================== + Hits 6184 6205 +21 + Misses 1 0 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dplewis commented 4 months ago

Type checking will be broken until ObjectStateMutations, ParsePush, ParseFile, ParseHook, ParseQuery, ParseUser are converted to TypeScript which will be done in the future.

mtrezza commented 4 months ago

So should we make the type check job optional in the CI and merge this?

dplewis commented 4 months ago

How do you make it optional?

dplewis commented 4 months ago

@mtrezza I made type checking optional for now. This is good to merge

mtrezza commented 4 months ago

I meant to remove the "required" option in the repo settings for that CI job. With your change the job will always pass in the CI, do we want that?

dplewis commented 4 months ago

@mtrezza I removed the CI change, do whatever you think is best.

parseplatformorg commented 4 months ago

🎉 This change has been released in version 5.1.0-alpha.9

parseplatformorg commented 3 months ago

🎉 This change has been released in version 5.1.0-beta.1

parseplatformorg commented 3 months ago

🎉 This change has been released in version 5.1.0