Closed dplewis closed 4 months ago
Closes: #123
in the PR description, so I can recognize it.All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
72bc9ac
) to head (2665a78
). Report is 20 commits behind head on alpha.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Type checking will be broken until ObjectStateMutations, ParsePush, ParseFile, ParseHook, ParseQuery, ParseUser are converted to TypeScript which will be done in the future.
So should we make the type check job optional in the CI and merge this?
How do you make it optional?
@mtrezza I made type checking optional for now. This is good to merge
I meant to remove the "required" option in the repo settings for that CI job. With your change the job will always pass in the CI, do we want that?
@mtrezza I removed the CI change, do whatever you think is best.
🎉 This change has been released in version 5.1.0-alpha.9
🎉 This change has been released in version 5.1.0-beta.1
🎉 This change has been released in version 5.1.0
Pull Request
Issue
Documentation missing from CoreManager.
Approach
Converting CoreManager to TypeScript will lay the foundation for future conversions. CoreManager will be the key to removing circular dependencies which is main issue when converting the entire project to TypeScript.