parse-community / Parse-SDK-JS

The JavaScript SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
1.32k stars 596 forks source link

fix: `Parse.GeoPoint.current` returns `undefined` #2127

Closed dplewis closed 3 months ago

dplewis commented 3 months ago

Pull Request

Issue

Parse.GeoPoint.current() uses a callback and returns undefined. This should resolve to a promise or allow callback as a parameter.

https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/getCurrentPosition

Approach

Tasks

parse-github-assistant[bot] commented 3 months ago

Thanks for opening this pull request!

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (72bc9ac) to head (88f2d9d). Report is 26 commits behind head on alpha.

:exclamation: Current head 88f2d9d differs from pull request most recent head c93032e. Consider uploading reports for the commit c93032e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## alpha #2127 +/- ## =========================================== + Coverage 99.98% 100.00% +0.01% =========================================== Files 61 64 +3 Lines 6185 6276 +91 Branches 1499 1508 +9 =========================================== + Hits 6184 6276 +92 + Misses 1 0 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

parseplatformorg commented 3 months ago

🎉 This change has been released in version 5.1.0-alpha.11

parseplatformorg commented 3 months ago

🎉 This change has been released in version 5.1.0-beta.1

parseplatformorg commented 3 months ago

🎉 This change has been released in version 5.1.0