style: Run Prettier for TypeScript declaration files

parse-community / Parse-SDK-JS

The JavaScript SDK for Parse Platform

https://parseplatform.org

Apache License 2.0

1.32k stars 596 forks source link

style: Run Prettier for TypeScript declaration files #2142

Closed dplewis closed 3 months ago

dplewis commented 3 months ago

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

TypeScript declaration files .d.ts are generated with tabs instead of spaces and other formatting issues. This will cause dtslint to fail. Running Prettier + Lint --fix against these files leaves only type correctness checks and tests.

Approach

Converts the following files to TS

FacebookUtils
ParseConfig
ParseOp
ParsePolygon
ParseSchema

Add Facebook types for global FB variable
Fixes the Check Types CI Job, this can now be a required job before merging PRs
Add TS test suite example

Tasks

[ ] Add tests
[ ] Add changes to documentation (guides, repository pages, code comments)

parse-github-assistant[bot] commented 3 months ago

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b50790a) to head (f782ce0). Report is 48 commits behind head on alpha.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## alpha #2142 +/- ## ========================================== Coverage 100.00% 100.00% ========================================== Files 61 64 +3 Lines 6186 6371 +185 Branches 1499 1511 +12 ========================================== + Hits 6186 6371 +185 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mtrezza commented 3 months ago

Quite impressive

parseplatformorg commented 2 months ago

🎉 This change has been released in version 5.2.0-alpha.2

parseplatformorg commented 1 month ago

🎉 This change has been released in version 5.2.0-beta.1

parseplatformorg commented 1 month ago

🎉 This change has been released in version 5.2.0