refactor: Remove Flow Type

parse-community / Parse-SDK-JS

The JavaScript SDK for Parse Platform

https://parseplatform.org

Apache License 2.0

1.32k stars 596 forks source link

refactor: Remove Flow Type #2145

Closed dplewis closed 3 months ago

dplewis commented 3 months ago

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Now that all files have been converted to typescript we no longer need flow types. To get flow type to work you would have to install flow-bin globally unlike parse server which runs flow along with eslint.

Approach

Remove @flow comment from files and remove all flow type plugins

Convert the following files to TS

EventuallyQueue
IndexDBStorageController
LiveQuerySubscription
ParseACL
ParseError
ParseLiveQuery
ParseRelation
SingleInstanceStateController
UniqueInstanceStateController

Tasks

[x] Add tests
[x] Add changes to documentation (guides, repository pages, code comments)

parse-github-assistant[bot] commented 3 months ago

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b50790a) to head (46f93cf). Report is 51 commits behind head on alpha.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## alpha #2145 +/- ## ========================================== Coverage 100.00% 100.00% ========================================== Files 61 64 +3 Lines 6186 6360 +174 Branches 1499 1534 +35 ========================================== + Hits 6186 6360 +174 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

parseplatformorg commented 2 months ago

🎉 This change has been released in version 5.2.0-alpha.2

parseplatformorg commented 1 month ago

🎉 This change has been released in version 5.2.0-beta.1

parseplatformorg commented 1 month ago

🎉 This change has been released in version 5.2.0