parse-community / Parse-SDK-JS

The JavaScript SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
1.31k stars 599 forks source link

Change fields in LiveQueryClient.resubscribe to keys #2180

Closed akichim21 closed 2 weeks ago

akichim21 commented 3 weeks ago

Issue Description

Change fields in LiveQueryClient.resubscribe to keys

https://github.com/parse-community/Parse-SDK-JS/blob/alpha/src/LiveQueryClient.ts#L303

Steps to reproduce

Actual Outcome

Environment

Server

parse-github-assistant[bot] commented 3 weeks ago

Thanks for opening this issue!

dplewis commented 3 weeks ago

Please update Parse Server and JS SDK to the latest version, this should fix your issue.

akichim21 commented 3 weeks ago

@dplewis Hi. In 5.2.0-alpha.2 it was still fields. Which version? The resubscribe one, not the subscribe one.

https://github.com/parse-community/Parse-SDK-JS/blob/56bc655e2a090cf8200dc22eba7732b09c7bcaff/src/LiveQueryClient.ts#L303

dplewis commented 3 weeks ago

Oh I see. This is a bug. Would you like to open a PR to fix it?

akichim21 commented 3 weeks ago

I tried to respond, but could not take the time to respond to the CI. https://github.com/parse-community/Parse-SDK-JS/pull/2182

I have addressed this with PATCH, but I hope it will be addressed on the library side.

When the server error occurred, the client would make multiple connections and the DISCONNECT did not occur immediately. The server stopped working due to the large number of connections.

dplewis commented 3 weeks ago

Thanks for the feedback. Thats a major issue, i'll see if I can write a test for it.

dplewis commented 3 weeks ago

@akichim21 I opened a PR for this https://github.com/parse-community/Parse-SDK-JS/pull/2184 if you want to check it out.

akichim21 commented 3 weeks ago

Thank you for your response. I check it.