ci: Properly handle open connections after the tests finish

parse-community / Parse-SDK-JS

The JavaScript SDK for Parse Platform

https://parseplatform.org

Apache License 2.0

1.31k stars 599 forks source link

ci: Properly handle open connections after the tests finish #2185

Closed dplewis closed 2 weeks ago

dplewis commented 3 weeks ago

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

I realized the the open connections to the server in the test suite are just the node process to run Jasmine. This causes a lot of clutter in the CI logs when trying to review PRs. Logging to console also slows down the test suite.

Approach

Keep all connections alive until end of the test suite
Remove destroying of open connections
Remove sleep(0) from execution
Perf: save ~10 seconds in the test suite

Tasks

[x] Add tests
[x] Add changes to documentation (guides, repository pages, code comments)

parse-github-assistant[bot] commented 3 weeks ago

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d76328c) to head (80effb0).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## alpha #2185 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 64 64 Lines 6364 6364 Branches 1535 1507 -28 ========================================= Hits 6364 6364 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

parseplatformorg commented 2 weeks ago

🎉 This change has been released in version 5.2.0-alpha.3

parseplatformorg commented 2 weeks ago

🎉 This change has been released in version 5.2.0-beta.1

parseplatformorg commented 2 weeks ago

🎉 This change has been released in version 5.2.0