parse-community / Parse-SDK-JS

The JavaScript SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
1.31k stars 599 forks source link

fix: Dot notation on JSON arrays doesn't work on `PushStatus` offset fields #2194

Closed dplewis closed 2 weeks ago

dplewis commented 2 weeks ago

…fset fields

Pull Request

Issue

With the introduction of dot notation on array fields. https://github.com/parse-community/Parse-SDK-JS/pull/2120 doesn't include a check for PushStatus.sentPerUTCOffset and PushStatus.failedPerUTCOffset. These fields are a weird mix of dot notation, JSON arrays with numeric offset and dynamic indexes (not a zero indexed json array like the check).

Screenshot 2024-06-27 at 8 43 53 PM

This should allow merging the JS SDK to the server, https://github.com/parse-community/parse-server/pull/9128

Screenshot 2024-06-27 at 2 02 28 PM

Approach

Check for PushStatus dot notation fields

Tasks

parse-github-assistant[bot] commented 2 weeks ago

Thanks for opening this pull request!

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b50790a) to head (d2e8ba7). Report is 88 commits behind head on alpha.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## alpha #2194 +/- ## ========================================== Coverage 100.00% 100.00% ========================================== Files 61 64 +3 Lines 6186 6366 +180 Branches 1499 1507 +8 ========================================== + Hits 6186 6366 +180 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

parseplatformorg commented 2 weeks ago

🎉 This change has been released in version 5.2.0-alpha.4

parseplatformorg commented 2 weeks ago

🎉 This change has been released in version 5.2.0-beta.2

parseplatformorg commented 2 weeks ago

🎉 This change has been released in version 5.2.0