stewartmiles commented 6 years ago

This labels Parse/Plugins/Unity.Tasks.dll (the real implementation) with the gvh_dotnet-3.5 label so that the DLL is only enabled by Version Handler (https://github.com/googlesamples/unity-jar-resolver) if .NET 4.x is enabled.

codecov[bot] commented 6 years ago

Codecov Report

Merging #285 into master will increase coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   67.21%   67.26%   +0.04%     
==========================================
  Files         127      127              
  Lines       10139    10139              
  Branches     1455     1455              
==========================================
+ Hits         6815     6820       +5     
  Misses       3127     3127              
+ Partials      197      192       -5

Impacted Files	Coverage Δ
ParseCore/Public/ParseObject.cs	`65.56% <0%> (+0.23%)`	:arrow_up:
ParseCore/Public/ParseQuery.cs	`16.32% <0%> (+0.45%)`	:arrow_up:
...rseCommon/Internal/Utilities/InternalExtensions.cs	`84.12% <0%> (+1.58%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce87d7f...788044e. Read the comment docs.

TobiasPott commented 4 years ago

Unfortunately this PR is outdated and due to recent changes to the repository and the structure of the assembly made by @TheFanatr the helper files for support of Tasks in older Unity versions is no longer necessary. Thus I close this PR, feel free to reopen it or create a new one for any improvements you can provide.

However, thank you for your contribution =)

parse-community / Parse-SDK-dotNET

Disable .NET 3.x Unity.Tasks.dll in .NET 4.x. #285

Codecov Report