Closed ryanmcdonough closed 4 years ago
Merging #330 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 56.48% 56.48%
=======================================
Files 91 91
Lines 6136 6136
Branches 1011 1011
=======================================
Hits 3466 3466
Misses 2490 2490
Partials 180 180
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update afbcf97...5538e05. Read the comment docs.
Hi @ryanmcdonough I've checked the pull request and your changes and appreciate your effort to add documentation to the code. I've noticed that you've introduced a typo for the "ApplicationID" property. It's shows "ApplicationIx". Could you fix this and update/resubmit your pull request?
Hey @TobiasPott thats sorted now.
Thank you very much @ryanmcdonough , another thing you may elaborate so I can understand the change is the change of the "Key" property to "WindowsKey". As the actual name of the property did not change I think it might be confusing using a different name in the Readme.md compared to the sources. Sorry for being picky on a PR for documentation, though.
@TobiasPott - totally understand, so when I was using the package locally it's using WindowsKey however reviewing the code on github it's just Key - i'll revert my change on that
@ryanmcdonough Thank you very much. =) I assume I'll get notified when you update this pull request and I'll proceed with merging it then.
All updated @TobiasPott :)
Thank you very much @ryanmcdonough Your pull request have been merged into the master branch.
I appreciate your contribution and your help. Feel free to continue to do so =).
Fix documentation regarding initializing the ParseClient