parse-community / Parse-SDK-dotNET

Parse SDK for .NET, Xamarin, Unity.
http://parseplatform.org
Apache License 2.0
322 stars 260 forks source link

fix: SDK crash on conversion of double type range values to long type #342

Closed TobiasPott closed 3 months ago

TobiasPott commented 3 years ago

This pull request targets the issue of values retrieved from parse-server exceeding the long64 value range mentioned in #339 It handles it by using a fallback to the double type with a higher range as this also would be the type with which the higher values can only be added to the parse-server using the .NET SDK.

It also includes a test checking for long max and min values and the double max and min values and the specific value mentioned in the issue.

@TheFanatr Could you take a look at this PR and give me feedback whether or not to change anything (especially the test part as I'm unsure if it will be sufficient)

saamerm commented 2 years ago

@TheFanatr @TobiasPott any update on this?

parse-github-assistant[bot] commented 3 months ago

Thanks for opening this pull request!

parseplatformorg commented 3 months ago

🎉 This change has been released in version 3.0.1