fix: SDK crashes when using `ParseQuery.include` with anonymous user

parse-community / Parse-SDK-dotNET

Parse SDK for .NET, Xamarin, Unity.

http://parseplatform.org

Apache License 2.0

322 stars 260 forks source link

Closed Werkezeugs closed 3 months ago

Werkezeugs commented 3 months ago

Hotfix crash for anonym User when using ParseQuery.Include()

For anonym users currently the project crashes with "Object reference not set to an Instance of an object"

this only happens if you use a ParseQuery with the .Include("") Keyword
Rootcause is serviceHub is null here --> cannot accesss the (serviceHub).Instance

Maybe consider to fix the rootcause, why is serviceHub null here? I couln´t determine yet. But this code change hotfixes the problem

parse-github-assistant[bot] commented 3 months ago

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

parse-github-assistant[bot] commented 3 months ago

I will reformat the title to use the proper commit message syntax.

mtrezza commented 3 months ago

@Werkezeugs why has this PR been closed?

Werkezeugs commented 2 months ago

Hi @mtrezza , This was by intention😉 found a better fix for the issue, just let me open a new PR on that

mtrezza commented 2 months ago

Maybe consider to fix the rootcause, why is serviceHub null here? I couln´t determine yet.

Maybe that would need to be investigated?