parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)
https://parseplatform.org
Other
2.81k stars 864 forks source link

fix: implementation via CocoaPods fails due to missing `FBSDKCoreKit` dependency #1666

Closed StevenMasini closed 1 year ago

StevenMasini commented 1 year ago

New Pull Request Checklist

Issue Description

Adding subspec Parse/FacebookUtils to a project will generate linking compilation issues, caused by the missing dependency FBSDKCoreKit.

Related issue: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1665

Approach

TODOs before merging

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

danipralea commented 1 year ago

is there any way we can merge this? @mtrezza

mtrezza commented 1 year ago

@StevenMasini Hasn't requested a review yet, so I'm not sure, is this ready? Does it fix the issue for you?

danipralea commented 1 year ago

I don't know to be honest. I can't say for sure until it gets merged. or maybe manually indicate his branch in Podfile?

StevenMasini commented 1 year ago

@mtrezza I am just wondering what's wrong with the ci/macos? I don't think my change caused that issue. Otherwise, I think it's ready to merge.

mtrezza commented 1 year ago

Yes, doesn't seem related, I'll go ahead and merge.

parseplatformorg commented 1 year ago

🎉 This change has been released in version 1.19.4