search

parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)
https://parseplatform.org
Other
2.81k stars 865 forks source link

Negative progress on downloads #1704

Closed richardgroves closed 1 year ago

richardgroves commented 1 year ago

It is possible to have a download progress block called with a negative progress value.

This occurs as the line:

https://github.com/parse-community/Parse-SDK-iOS-OSX/blob/b6ec05c8ea17d936cb695713d11e0a61854bfe84/Parse/Parse/Internal/Commands/CommandRunner/URLSession/Session/TaskDelegate/PFURLSessionFileDownloadTaskDelegate.m#L62

does not include a check for self.response.expectedContentLength == NSURLResponseUnknownLength (NSURLResponseUnknownLength = -1).

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this issue!

richardgroves commented 1 year ago

Closing as the GitHub 'start a new issue from a line of code in the browser' doesn't start with the template required here, and back porting template in seems like a PITA - see https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1705#issue-1579818082 instead