parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)
https://parseplatform.org
Other
2.81k stars 865 forks source link

feat: Add LiveQuery module to SDK #1712

Closed vazarkevych closed 1 year ago

vazarkevych commented 1 year ago

New Pull Request Checklist

Issue

Closes: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1714

TODOs before merging

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

mtrezza commented 1 year ago

@vazarkevych Could you give a description of the issues that are stopping this PR currently?

And could you please do a rebase to resolve the conflicts? Maybe the latest workflow changes address some of the issues. If you have any questions regarding the new workflow, maybe @dplewis could give a hand...

dplewis commented 1 year ago

@vazarkevych I can give a hand, can you give me access to your fork?

vazarkevych commented 1 year ago

@dplewis I gave access you to my fork

vazarkevych commented 1 year ago

Hi, @dplewis, Just a kind follow-up regarding the status of the ParseLiveQuery. Do you have any updates on your side?

dplewis commented 1 year ago

@vazarkevych I fixed the merge conflict waiting for CI to pass

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (cbab34c) 78.17% compared to head (413aec7) 78.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1712 +/- ## ========================================== - Coverage 78.17% 78.16% -0.01% ========================================== Files 307 307 Lines 36803 36803 ========================================== - Hits 28770 28768 -2 - Misses 8033 8035 +2 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1712/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dplewis commented 1 year ago

@vazarkevych I got the live query project to build successfully, looks like the release build is broken

dplewis commented 1 year ago

@vazarkevych I got the release working but ParseLiveQuery-OSX is broken. I don't know why BoltsSwift is compiling to macOS 10.10 in the CI and locally for me.

❌  /Users/runner/work/Parse-SDK-iOS-OSX/Parse-SDK-iOS-OSX/ParseLiveQuery/ParseLiveQuery/Internal/ClientPrivate.swift:13:8: compiling for macOS 10.10, but module 'BoltsSwift' has a minimum deployment target of macOS 10.15: /Users/runner/work/Parse-SDK-iOS-OSX/Parse-SDK-iOS-OSX/build/macOS/Release-osx-macosx/BoltsSwift.framework/Modules/BoltsSwift.swiftmodule/x86_64-apple-macos.swiftmodule
dplewis commented 1 year ago

@vazarkevych @mtrezza The project builds , the examples compile and run, and the CI is working. I'm not familiar with how SPM works, can you check it?

mtrezza commented 1 year ago

@vazarkevych Could you look into the remaining issues so we can get this merged?

vazarkevych commented 1 year ago

Hi @dplewis, thank you for your contribution. I just checked SPM, and it stopped working

dplewis commented 1 year ago

@vazarkevych I don't think I changed anything SPM related.

dplewis commented 1 year ago

@vazarkevych @mtrezza I got this to work via SPM. I added ParseObjC and ParseLiveQuery to my project from your github url and addParseLiveQuery branch. Then used

#import "Parse.h"
@import ParseLiveQuery;

I just checked SPM, and it stopped working

What stopped working?

mtrezza commented 1 year ago

Amazing! Maybe we could at least copy/paste the LiveQuery README to this README under a new chapter? Or is that content now outdated because of the migration?

dplewis commented 1 year ago

That documentation is outdated and very hard to get working for new users, I can't get it working. Once the project is migrated the LiveQuery code needs some TLC

mtrezza commented 1 year ago

Got it, then let's just wait for a review by @vazarkevych to confirm all is working as expected and then merge.

mtrezza commented 1 year ago

Anyone could try this out and confirm the LiveQuery module is working?

@parse-community/ios-sdk @extnous @HackShitUp

dplewis commented 1 year ago

@mtrezza @vazarkevych @VolodyaNazarkevych This is ready for review.

TODO: https://github.com/parse-community/Parse-SDK-iOS-OSX/pull/1712#pullrequestreview-1383664968

mtrezza commented 1 year ago

Amazing! @VolodyaNazarkevych Could you please take a look at this and test this module out in a project?

parseplatformorg commented 1 year ago

🎉 This change has been released in version 2.3.0