Closed vazarkevych closed 1 year ago
@vazarkevych Could you give a description of the issues that are stopping this PR currently?
And could you please do a rebase to resolve the conflicts? Maybe the latest workflow changes address some of the issues. If you have any questions regarding the new workflow, maybe @dplewis could give a hand...
@vazarkevych I can give a hand, can you give me access to your fork?
@dplewis I gave access you to my fork
Hi, @dplewis, Just a kind follow-up regarding the status of the ParseLiveQuery. Do you have any updates on your side?
@vazarkevych I fixed the merge conflict waiting for CI to pass
Patch coverage has no change and project coverage change: -0.01
:warning:
Comparison is base (
cbab34c
) 78.17% compared to head (413aec7
) 78.16%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@vazarkevych I got the live query project to build successfully, looks like the release build is broken
@vazarkevych I got the release working but ParseLiveQuery-OSX is broken. I don't know why BoltsSwift is compiling to macOS 10.10 in the CI and locally for me.
❌ /Users/runner/work/Parse-SDK-iOS-OSX/Parse-SDK-iOS-OSX/ParseLiveQuery/ParseLiveQuery/Internal/ClientPrivate.swift:13:8: compiling for macOS 10.10, but module 'BoltsSwift' has a minimum deployment target of macOS 10.15: /Users/runner/work/Parse-SDK-iOS-OSX/Parse-SDK-iOS-OSX/build/macOS/Release-osx-macosx/BoltsSwift.framework/Modules/BoltsSwift.swiftmodule/x86_64-apple-macos.swiftmodule
@vazarkevych @mtrezza The project builds , the examples compile and run, and the CI is working. I'm not familiar with how SPM works, can you check it?
@vazarkevych Could you look into the remaining issues so we can get this merged?
Hi @dplewis, thank you for your contribution. I just checked SPM, and it stopped working
@vazarkevych I don't think I changed anything SPM related.
@vazarkevych @mtrezza I got this to work via SPM. I added ParseObjC and ParseLiveQuery to my project from your github url and addParseLiveQuery branch. Then used
#import "Parse.h"
@import ParseLiveQuery;
I just checked SPM, and it stopped working
What stopped working?
Amazing! Maybe we could at least copy/paste the LiveQuery README to this README under a new chapter? Or is that content now outdated because of the migration?
That documentation is outdated and very hard to get working for new users, I can't get it working. Once the project is migrated the LiveQuery code needs some TLC
Got it, then let's just wait for a review by @vazarkevych to confirm all is working as expected and then merge.
Anyone could try this out and confirm the LiveQuery module is working?
@parse-community/ios-sdk @extnous @HackShitUp
@mtrezza @vazarkevych @VolodyaNazarkevych This is ready for review.
TODO: https://github.com/parse-community/Parse-SDK-iOS-OSX/pull/1712#pullrequestreview-1383664968
Amazing! @VolodyaNazarkevych Could you please take a look at this and test this module out in a project?
🎉 This change has been released in version 2.3.0
New Pull Request Checklist
Issue
Closes: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1714
TODOs before merging