parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)
https://parseplatform.org
Other
2.81k stars 865 forks source link

Add LiveQuery as module #1714

Closed mtrezza closed 1 year ago

mtrezza commented 1 year ago

New Feature / Enhancement Checklist

Current Limitation

The LiveQuery SDK is separate from the main SDK. Since the main SDK has SPM support, LiveQuery can be added as a module.

Feature / Enhancement Description

Add LiveQuery as a module.

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this issue!

mtrezza commented 1 year ago

@project-academy The LiveQuery module has been merged and released as version 2.3.0; could you please try it out and let us know in case you find any issues?

proj-sashido commented 1 year ago

Did some light testing, looks like things are working - thank you!

mtrezza commented 1 year ago

Amazing, thanks for the feedback, @project-academy; if you could do some more testing and/or find anything weird, please let us know and open an issue. We'll go ahead an archive the other repository.

cc @dplewis

mtrezza commented 1 year ago

@sidan5, @extnous, @bayareahank, @owais-applligent, @ChrisCoder9000, @ULSashido, @ritteraf, @HackShitUp, @432player it would be great if you could also test this LiveQuery module out and let us know any feedback

joaquin102 commented 10 months ago

Hey everyone.

I installed this module from 2.7.0 and right out of the box there is an issue with WebSocketDelegate

I am attaching here the screenshot but the main 2 issues are:

These errors can be found on ClientPrivate.swift file of the ParseLiveQuery module.

Screenshot 2023-09-04 at 1 00 28 AM
mtrezza commented 10 months ago

Interesting that this wasn't picked up by any LiveQuery test in the CI, if it's such a fundamental issue.

@joaquin102 Do you want to open a PR and test to fix this? @vazarkevych Could you take a look at this? @dplewis Wasn't this an issue you've mentioned recently in a chat?

project-saf commented 10 months ago

I noticed this too - it's a change that was made in Starscream v4.0.6 The workaround in the meantime is to add Starscream as a package to your project, and set to the exact version v4.0.4 https://github.com/daltoniam/Starscream.git

dplewis commented 10 months ago

@mtrezza I moved the project but never used in production unfortunately.

@cbaker6 I’m still learning swift can you help out?

joaquin102 commented 10 months ago

Sure @mtrezza I'll give it a try!

I can also confirm that the workaround suggested by @project-saf worked👍. The error is gone.

Also, and my apologies if this is not the right channel to post this question (I can delete it if this is not appropriate here), but I'm trying to implement ParseLiveQuery on my iOS app but I can't make it to work. I've spent days on this but I always get the error cannot decode json into I feel this is a silly error on my end. Does anyone know about this? I posted a full description on stackoverflow:

https://stackoverflow.com/questions/77046879/unable-to-get-parse-ios-sdk-livequery-to-work-always-get-cannot-decode-json-in

Thank you for your help!

mtrezza commented 10 months ago

@joaquin102 Thanks a bunch. Regarding your issue, you could also post in the community forum, just make sure to cross-reference with the SO post, to reduce people's efforts.