parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)
https://parseplatform.org
Other
2.81k stars 871 forks source link

ci: Fix test coverage with codecov #1726

Closed dplewis closed 1 year ago

dplewis commented 1 year ago

New Pull Request Checklist

Issue Description

Code coverage has been broken for a while with a number of factors contributing to it. actions/codecov@3.1.0 introduced xcode support. I'm not sure if CODECOV_TOKEN is in the in the repository secrets

https://github.com/codecov/codecov-action/releases/tag/v3.1.0

Approach

TODO

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

dplewis commented 1 year ago

@mtrezza I think it works, I don't have full access to codecov.

https://app.codecov.io/github/parse-community/Parse-SDK-iOS-OSX/commit/f9615fd91c75718a09539f359b85fb138f6e2840/tree

mtrezza commented 1 year ago

I'm not sure if CODECOV_TOKEN is in the in the repository secrets

We don't have a token in the secrets, IIRC that's not necessary.

It seems to work; it's actually a pretty good coverage:

image
dplewis commented 1 year ago

@mtrezza This is ready for review. Here is what the coverage looks like with everything included

https://app.codecov.io/github/parse-community/Parse-SDK-iOS-OSX/commit/58c9c5be43bb403982effadee84be31d620d18c1/tree

dplewis commented 1 year ago

@mtrezza I made the changes. Can you review it again?

parseplatformorg commented 1 year ago

🎉 This change has been released in version 2.3.0