parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)
https://parseplatform.org
Other
2.81k stars 865 forks source link

fix: Compilation error on macOS `Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler` #1739

Closed dplewis closed 10 months ago

dplewis commented 10 months ago

New Pull Request Checklist

Issue Description

PFProduct and PFPurchase aren't supported on MacOS

Closes: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1699

Approach

TODOs before merging

parse-github-assistant[bot] commented 10 months ago

Thanks for opening this pull request!

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (2316a3f) 77.86% compared to head (1975c55) 78.22%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1739 +/- ## ========================================== + Coverage 77.86% 78.22% +0.35% ========================================== Files 299 307 +8 Lines 36328 36981 +653 ========================================== + Hits 28288 28927 +639 - Misses 8040 8054 +14 ``` | [Files](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1739?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | Coverage Δ | | |---|---|---| | [...nternal/Purchase/Controller/PFPurchaseController.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1739?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2UvUGFyc2UvSW50ZXJuYWwvUHVyY2hhc2UvQ29udHJvbGxlci9QRlB1cmNoYXNlQ29udHJvbGxlci5t) | `88.81% <ø> (ø)` | | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1739/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mtrezza commented 10 months ago

I've changed the PR title, could you check whether it's correct? As a reminder, the PR title will be part of the changelog and should describe what the bug is, rather than what the solution or fixed state is.

dplewis commented 10 months ago

That is correct

parseplatformorg commented 10 months ago

🎉 This change has been released in version 2.7.1