ci: Remove Release assets

parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)

https://parseplatform.org

Other

2.81k stars 865 forks source link

ci: Remove Release assets #1741

Closed dplewis closed 9 months ago

dplewis commented 10 months ago

New Pull Request Checklist

[ ] I am not disclosing a vulnerability.
[ ] I am creating this PR in reference to an issue.

Issue Description

Removes release assets from release

Closes: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1740

Approach

Remove assets from CI
Update README instructions

TODOs before merging

[x] Add tests
[x] Add changes to documentation (guides, repository pages, in-code descriptions)

parse-github-assistant[bot] commented 10 months ago

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (7231bf7) 78.23% compared to head (42a0f02) 64.43%. Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1741 +/- ## =========================================== - Coverage 78.23% 64.43% -13.81% =========================================== Files 307 200 -107 Lines 36981 23177 -13804 =========================================== - Hits 28931 14933 -13998 - Misses 8050 8244 +194 ``` [see 124 files with indirect coverage changes](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1741/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dplewis commented 10 months ago

@mtrezza this is ready for review

mtrezza commented 9 months ago

I seem to remember that we recently did not have assets in releases and there was someone requesting they'd be added. I'm not sure about the use cases for these assets. Any good reason someone would need to add the SDK as a file directly to a Xcode project instead of using SPM?

dplewis commented 9 months ago

I seem to remember that we recently did not have assets in releases

Assets have been available since the beginning of the SDK.

Any good reason someone would need to add the SDK as a file directly

I'm also not sure about the use cases for these assets unless they can't get SPM to work. @parse-community/ios-sdk any idea?

mtrezza commented 9 months ago

Assets have been available since the beginning of the SDK.

They haven't been available at some point, I believe with the introduction with SPM. We even have added a manual CI workflow to add the assets in case the process fails. I remember there was a complaint, but I can't find it.

mtrezza commented 9 months ago

Let's leave this open for some days and the go ahead and remove them, I'd suggest.

dplewis commented 9 months ago

@mtrezza A use case is if you need to develop using an offline or static framework.

mtrezza commented 9 months ago

I'm continuing the discussion in https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1740#issuecomment-1747122373, because it's not PR related.

mtrezza commented 9 months ago

@dplewis I notice that this PR contains some changes to the README that are missing in https://github.com/parse-community/Parse-SDK-iOS-OSX/pull/1744. Is this PR still useful?

dplewis commented 9 months ago

I’ll create another PR as there maybe merge conflicts. This PR is useful because it removes publishing the assets to GitHub on version release

mtrezza commented 9 months ago

Other PR: https://github.com/parse-community/Parse-SDK-iOS-OSX/pull/1745