parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)
https://parseplatform.org
Other
2.81k stars 871 forks source link

ci: Fix and build Starter Projects #1744

Closed dplewis closed 1 year ago

dplewis commented 1 year ago

New Pull Request Checklist

Issue Description

The code for building starter projects does exists but was never used and didn't work when used. Because they weren't use a lot of issues could have been caught.

Approach

TODOs before merging

TODOs after merging

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (7231bf7) 78.23% compared to head (921b6ee) 83.02%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1744 +/- ## ========================================== + Coverage 78.23% 83.02% +4.79% ========================================== Files 307 261 -46 Lines 36981 31675 -5306 ========================================== - Hits 28931 26298 -2633 + Misses 8050 5377 -2673 ``` [see 74 files with indirect coverage changes](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1744/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dplewis commented 1 year ago

@mtrezza This is ready for review

parseplatformorg commented 1 year ago

🎉 This change has been released in version 2.7.2