parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)
https://parseplatform.org
Other
2.81k stars 871 forks source link

fix: Compilation errors `Undefined symbol` and `SystemConfiguration not found` on watchOS #1748

Closed dplewis closed 1 year ago

dplewis commented 1 year ago

New Pull Request Checklist

Issue Description

Building the framework against watchOS starter project won't build

Closes: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1746 Closes: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1743

Approach

TODOs before merging

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (9fda428) 63.44% compared to head (b953863) 64.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1748 +/- ## ========================================== + Coverage 63.44% 64.43% +0.98% ========================================== Files 192 200 +8 Lines 22524 23177 +653 ========================================== + Hits 14291 14933 +642 - Misses 8233 8244 +11 ``` | [Files](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | Coverage Δ | | |---|---|---| | [...Installation/Controller/PFInstallationController.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2UvUGFyc2UvSW50ZXJuYWwvSW5zdGFsbGF0aW9uL0NvbnRyb2xsZXIvUEZJbnN0YWxsYXRpb25Db250cm9sbGVyLm0=) | `0.00% <ø> (ø)` | | | [...lationController/PFCurrentInstallationController.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2UvUGFyc2UvSW50ZXJuYWwvSW5zdGFsbGF0aW9uL0N1cnJlbnRJbnN0YWxsYXRpb25Db250cm9sbGVyL1BGQ3VycmVudEluc3RhbGxhdGlvbkNvbnRyb2xsZXIubQ==) | `69.64% <ø> (ø)` | | | [Parse/Parse/Internal/PFReachability.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2UvUGFyc2UvSW50ZXJuYWwvUEZSZWFjaGFiaWxpdHkubQ==) | `80.50% <ø> (ø)` | | | [...rse/Parse/Internal/Push/Utilites/PFPushUtilities.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2UvUGFyc2UvSW50ZXJuYWwvUHVzaC9VdGlsaXRlcy9QRlB1c2hVdGlsaXRpZXMubQ==) | `47.61% <ø> (ø)` | | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1748/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dplewis commented 1 year ago

The starter projects work locally for me. I updated the starter projects on Xcode 15 and macOS 17, M1 Chip. I'll do more investigation on why it's failing

dplewis commented 1 year ago

@mtrezza This is ready for merge.

parseplatformorg commented 1 year ago

🎉 This change has been released in version 2.7.2