fix: Compilation errors in `ParseLiveQuery` using `Starscream` 4.0.6

parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)

https://parseplatform.org

Other

2.81k stars 871 forks source link

fix: Compilation errors in `ParseLiveQuery` using `Starscream` 4.0.6 #1749

Closed dplewis closed 1 year ago

dplewis commented 1 year ago

New Pull Request Checklist

[ ] I am not disclosing a vulnerability.
[ ] I am creating this PR in reference to an issue.

Issue Description

There are many reasons why these issues could occur.

Type 'Client' does not conform to protocol Switch must be exhaustive

Closes: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1738

Approach

You can replicate this issue by adding ParseLiveQuery to the tvOS starter project via SPM.

Bump starscream to 4.0.6
Remove starscream from Carthage
Remove bolts-swift from Carthage
Add starscream changes from update
Add local SDK from SPM to tvOS starter
Deploy for iOS 12

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (79a92ac) 78.22% compared to head (530857c) 78.22%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1749 +/- ## ======================================= Coverage 78.22% 78.22% ======================================= Files 307 307 Lines 36981 36981 ======================================= + Hits 28927 28929 +2 + Misses 8054 8052 -2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1749/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dplewis commented 1 year ago

When adding Starscream to the ParseLiveQuery project as a swift package dependency I got this. I'm using my own fork for now.

mtrezza commented 1 year ago

How is that possible for a public repository? Did you try https://stackoverflow.com/questions/58816416/xcode-swift-package-manager-error-the-repository-could-not-be-found?

Also, there is a repository= prefix in the dialog text, not sure if that's expected.

dplewis commented 1 year ago

I figured it out

dplewis commented 1 year ago

@mtrezza This is ready to merge.

parseplatformorg commented 1 year ago

🎉 This change has been released in version 2.7.3