Closed dplewis closed 9 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
c4998e6
) 11.24% compared to head (137e9a5
) 64.40%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Removed myself from review since there have been more commits after the request. When this is ready for review please request again from @parse-community/ios-sdk-review
I would but it looks like you aren't a member of @parse-community/ios-sdk-review. Do you get notified?
You are right; I'm now
Yes
Watch OS 2 and 3 are over 7 years old. Yes this could be a breaking change.
Is the removal of watchOS 2 and 3 compatibility required to remove the OCMock Carthage dependency?
OCMock minimum version has always been watchOS 4
For reverence
Bolts-Swift is v3 Bolts-Objc is v2 Starscream is v2
@mtrezza If you build this PR you will see dependency 'OCMock' is not used by any target
. It's basically a dev dependency.
WatchOS 4 is the minimum support for Xcode 14+
The Xcode 14 release supports on-device debugging in iOS 11 and later, tvOS 11 and later, and watchOS 4 and later. Xcode 14 requires a Mac running macOS Monterey 12.5 or later.
Xcode won't let me choose a target less than WatchOS 4
So the watchOS bump is unrelated to the removal of OCMock? If that is so, I think it would be better to do that in a separate PR.
@mtrezza Changes have been made. Flaky test causing CI to fail. This is ready to merge no need to restart the CI.
Do you want to open another PR to bump the deployment target to watchOS 4?
We support Xcode 14+, any developer making a WatchOS app is forced to use WatchOS 4+. 4 > 2 so there will never be an issue. If the Repo was developed specifically for WatchOS then I would do a PR.
But why did you bump this in the first place then?
I thought I was right at the time. I'm still learning. This project hasn't been worked on in a long time. Maybe I'm still right. I know why this project supports iOS 12 as a minimum do you?
I've mentioned my concerns about support policy of older versions in https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1755. Maybe the discussion should continue there.
Do what you have to, just don't increase the CI build time. Thats the only reason by I'm working on this project right now. I don't work on the parse-server anymore because of the / your policy
Not sure what you mean by that, but as always please feel free to open an issue in the Parse Server repository if you feel that a policy there is making it difficult for you to contribute.
🎉 This change has been released in version 3.0.0
New Pull Request Checklist
Issue Description
Closes: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1747
Approach
TODOs before merging