parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)
https://parseplatform.org
Other
2.81k stars 871 forks source link

test: [DO NOT MERGE] Run ParseUI Swift Demo without Dynamic Targets #1757

Closed dplewis closed 1 year ago

dplewis commented 1 year ago

New Pull Request Checklist

Issue Description

The only way to remove Bolts from Carthage is to remove all Dynamic Targets. ParseUI Swift Demo is the only target using it. I'm wondering why its not included in the CI build. If this test fails then we will have to remove the ParseUI swift support from the Repo unless we want to keep Bolts Carthage.

Looks like Bolts Carthage has already started failing in other Jobs

https://github.com/parse-community/Parse-SDK-iOS-OSX/actions/runs/6441796016/job/17491943259?pr=1756 https://github.com/parse-community/Parse-SDK-iOS-OSX/actions/runs/6440880523/job/17490133303

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

dplewis commented 1 year ago

@mtrezza Looks like Bolts Carthage is broken. I can't run this test.

mtrezza commented 1 year ago

Then should we remove the ParseUI?

dplewis commented 1 year ago

Then should we remove the ParseUI?

Yes please! Users should be making their own UI

mtrezza commented 1 year ago

I agree, this to me seem like it used to be a convenience feature back in the days, but today - especially with SwiftUI - building a layout has become a lot easier. I believe we can remove that.

dplewis commented 1 year ago

@mtrezza Can you open an issue?

mtrezza commented 1 year ago

See https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1760

dplewis commented 1 year ago

Closing via https://github.com/parse-community/Parse-SDK-iOS-OSX/pull/1763