refactor: Remove Carthage dependency

dplewis commented 9 months ago

New Pull Request Checklist

[x] I am not disclosing a vulnerability.
[x] I am creating this PR in reference to an issue.

Issue Description

With the removal of Carthage support a lot of legacy code has been leftover. This PR replaces Carthage dependencies with SPM. Carthage is currently breaking the CI

Closes: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1759, https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1747, https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1729, https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1706

Approach

Use Facebook SDK via SPM
Use Bolts SDK via SPM
Fix ParseUI Swift Demo
Remove recompile from source .xcodeproj references
Remove carthage ci cache
Remove cartfile and git submodules
Use SPM imports whenever possible

TODOs before merging

[x] Add tests
[x] Add changes to documentation (guides, repository pages, in-code descriptions)

parse-github-assistant[bot] commented 9 months ago

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (c4998e6) 11.24% compared to head (dadfd0e) 64.23%. Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1763 +/- ## =========================================== + Coverage 11.24% 64.23% +52.99% =========================================== Files 195 201 +6 Lines 23015 23233 +218 =========================================== + Hits 2587 14924 +12337 + Misses 20428 8309 -12119 ``` | [Files](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | Coverage Δ | | |---|---|---| | [...kUtils/ParseFacebookUtils/Source/PFFacebookUtils.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2VGYWNlYm9va1V0aWxzL1BhcnNlRmFjZWJvb2tVdGlscy9Tb3VyY2UvUEZGYWNlYm9va1V0aWxzLm0=) | `93.91% <ø> (ø)` | | | [...nProvider/PFFacebookMobileAuthenticationProvider.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2VGYWNlYm9va1V0aWxzaU9TL1BhcnNlRmFjZWJvb2tVdGlsc2lPUy9JbnRlcm5hbC9BdXRoZW50aWNhdGlvblByb3ZpZGVyL1BGRmFjZWJvb2tNb2JpbGVBdXRoZW50aWNhdGlvblByb3ZpZGVyLm0=) | `100.00% <ø> (ø)` | | | [...rseFacebookUtilsiOS/Source/PFFacebookUtilsDevice.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2VGYWNlYm9va1V0aWxzaU9TL1BhcnNlRmFjZWJvb2tVdGlsc2lPUy9Tb3VyY2UvUEZGYWNlYm9va1V0aWxzRGV2aWNlLm0=) | `100.00% <ø> (ø)` | | | [...S/Tests/Unit/FacebookAuthenticationProviderTests.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2VGYWNlYm9va1V0aWxzaU9TL1Rlc3RzL1VuaXQvRmFjZWJvb2tBdXRoZW50aWNhdGlvblByb3ZpZGVyVGVzdHMubQ==) | `100.00% <ø> (ø)` | | | [...seFacebookUtilsiOS/Tests/Unit/FacebookUtilsTests.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2VGYWNlYm9va1V0aWxzaU9TL1Rlc3RzL1VuaXQvRmFjZWJvb2tVdGlsc1Rlc3RzLm0=) | `100.00% <ø> (ø)` | | | [...eTwitterUtils/Internal/Dialog/PFOAuth1FlowDialog.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2VUd2l0dGVyVXRpbHMvUGFyc2VUd2l0dGVyVXRpbHMvSW50ZXJuYWwvRGlhbG9nL1BGT0F1dGgxRmxvd0RpYWxvZy5t) | `66.21% <ø> (ø)` | | | [...erUtils/Internal/PFTwitterAuthenticationProvider.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2VUd2l0dGVyVXRpbHMvUGFyc2VUd2l0dGVyVXRpbHMvSW50ZXJuYWwvUEZUd2l0dGVyQXV0aGVudGljYXRpb25Qcm92aWRlci5t) | `90.56% <ø> (ø)` | | | [...terUtils/ParseTwitterUtils/Source/PFTwitterUtils.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2VUd2l0dGVyVXRpbHMvUGFyc2VUd2l0dGVyVXRpbHMvU291cmNlL1BGVHdpdHRlclV0aWxzLm0=) | `17.39% <ø> (ø)` | | | [...TwitterUtils/ParseTwitterUtils/Source/PF\_Twitter.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2VUd2l0dGVyVXRpbHMvUGFyc2VUd2l0dGVyVXRpbHMvU291cmNlL1BGX1R3aXR0ZXIubQ==) | `87.43% <ø> (ø)` | | | [...ls/Tests/Unit/TwitterAuthenticationProviderTests.m](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-UGFyc2VUd2l0dGVyVXRpbHMvVGVzdHMvVW5pdC9Ud2l0dGVyQXV0aGVudGljYXRpb25Qcm92aWRlclRlc3RzLm0=) | `100.00% <ø> (ø)` | | | ... and [9 more](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | | ... and [143 files with indirect coverage changes](https://app.codecov.io/gh/parse-community/Parse-SDK-iOS-OSX/pull/1763/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dplewis commented 8 months ago

@mtrezza This is ready for review and merge.

parseplatformorg commented 3 months ago

🎉 This change has been released in version 3.0.0

parse-community / Parse-SDK-iOS-OSX