parse-community / Parse-SDK-iOS-OSX

The Apple SDK for Parse Platform (iOS, macOS, watchOS, tvOS)
https://parseplatform.org
Other
2.81k stars 865 forks source link

feat: Update Facebook SDK dependency to latest version 16.x and remove ParseFacebookUtilsTvOS #1774

Closed matteolongeri-ovolab closed 3 months ago

matteolongeri-ovolab commented 3 months ago

New Pull Request Checklist

Issue Description

This pull request increases Facebook SDK dependency to the latest version 16.x, giving apps the possibility to use it (actually they are limited to 15.x version, due to Parse dependency). In addition ParseFacebookUtilsTvOS has been removed, since with version 16.x Facebook SDK has dropped support for FacebookTV.

Closes: #1773 Closes: #1764

Approach

The Package.swift manifest has been edited and ParseFacebookUtilsTvOS directory has been removed.

TODOs before merging

parse-github-assistant[bot] commented 3 months ago

Thanks for opening this pull request!

mtrezza commented 3 months ago

Why don't we remove FacebookUtils in general? I don't think that the Parse SDK should restrict the developer in which Facebook SDK to use, and this has been a constant topic with the current implementation.

mtrezza commented 3 months ago

Closing via https://github.com/parse-community/Parse-SDK-iOS-OSX/pull/1779