Closed cbaker6 closed 2 years ago
Merging #309 (f415143) into main (fdbb1d9) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #309 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 114 114
Lines 11661 11661
=======================================
Hits 9861 9861
Misses 1800 1800
Impacted Files | Coverage Δ | |
---|---|---|
...entication/3rd Party/ParseGithub/ParseGitHub.swift | 100.00% <100.00%> (ø) |
|
...cation/3rd Party/ParseLinkedIn/ParseLinkedIn.swift | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fdbb1d9...f415143. Read the comment docs.
New Pull Request Checklist
Issue Description
Recently added auth:
ParseGitHub
andParseLinkedIn
properties are casedgitHub
andlinkedIn
respectively.Related issue: #n/a
Approach
Make all casing lower case for properties named after their auth type. This makes of the
ParseAuthentication
auths look the same and makes it easier to copy/paste/modify new adapters in the future.TODOs before merging