parse-community / Parse-Swift

The Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, Linux, Android, Windows)
https://parseplatform.org
MIT License
308 stars 69 forks source link

refactor: make properties for ParseGitHub, ParseLinkedIn lowercase #309

Closed cbaker6 closed 2 years ago

cbaker6 commented 2 years ago

New Pull Request Checklist

Issue Description

Recently added auth: ParseGitHub and ParseLinkedIn properties are cased gitHub and linkedIn respectively.

Related issue: #n/a

Approach

Make all casing lower case for properties named after their auth type. This makes of the ParseAuthentication auths look the same and makes it easier to copy/paste/modify new adapters in the future.

TODOs before merging

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

codecov[bot] commented 2 years ago

Codecov Report

Merging #309 (f415143) into main (fdbb1d9) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         114      114           
  Lines       11661    11661           
=======================================
  Hits         9861     9861           
  Misses       1800     1800           
Impacted Files Coverage Δ
...entication/3rd Party/ParseGithub/ParseGitHub.swift 100.00% <100.00%> (ø)
...cation/3rd Party/ParseLinkedIn/ParseLinkedIn.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdbb1d9...f415143. Read the comment docs.