parse-community / Parse-Swift

The Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, Linux, Android, Windows)
https://parseplatform.org
MIT License
308 stars 69 forks source link

refactor: change boolean config params to match Swift #311

Closed cbaker6 closed 2 years ago

cbaker6 commented 2 years ago

New Pull Request Checklist

Issue Description

Boolean config parameters should began with is to match standard Swift conventions.

Related issue: #n/a

Approach

Change the relevant config parameters. This is a breaking change, but the compiler should help update the names.

Changes you will need to make to your ParseSwift initialization/configuration:

TODOs before merging

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

codecov[bot] commented 2 years ago

Codecov Report

Merging #311 (2ee5ab8) into main (6a7f5c7) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   84.59%   84.67%   +0.07%     
==========================================
  Files         114      114              
  Lines       11700    11701       +1     
==========================================
+ Hits         9898     9908      +10     
+ Misses       1802     1793       -9     
Impacted Files Coverage Δ
...s/ParseSwift/Objects/ParseInstallation+async.swift 100.00% <ø> (ø)
...ParseSwift/Objects/ParseInstallation+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject+async.swift 100.00% <ø> (ø)
...urces/ParseSwift/Objects/ParseObject+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 81.46% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.27% <ø> (ø)
Sources/ParseSwift/API/API+Command.swift 83.80% <100.00%> (+0.03%) :arrow_up:
Sources/ParseSwift/Coding/ParseEncoder.swift 74.23% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 80.66% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a7f5c7...2ee5ab8. Read the comment docs.