search

parse-community / Parse-Swift

The Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, Linux, Android, Windows)
https://parseplatform.org
MIT License
306 stars 69 forks source link

refactor: remove bool comparisons to decrease build times #317

Closed cbaker6 closed 2 years ago

cbaker6 commented 2 years ago

New Pull Request Checklist

Issue Description

Comparing bools lead to increase build times. Reference: https://forums.swift.org/t/boolean-comparison-causes-extremely-slow-compilation/41609

Related issue: #n/a

Approach

Remove unnecessary comparisons knocks ~3 seconds off of build.

TODOs before merging

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

codecov[bot] commented 2 years ago

Codecov Report

Merging #317 (d0ef915) into main (b92667f) will not change coverage. The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   84.62%   84.62%           
=======================================
  Files         114      114           
  Lines       11845    11845           
=======================================
  Hits        10024    10024           
  Misses       1821     1821
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseUser.swift 80.69% <50.00%> (ø)
Sources/ParseSwift/Extensions/URLSession.swift 72.46% <100.00%> (ø)
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 72.92% <100.00%> (ø)
Sources/ParseSwift/Parse.swift 98.77% <100.00%> (ø)
Sources/ParseSwift/Types/ParseError.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b92667f...d0ef915. Read the comment docs.