parse-community / Parse-Swift

The Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, Linux, Android, Windows)
https://parseplatform.org
MIT License
306 stars 69 forks source link

refactor: user Swift convention for parameter names #321

Closed cbaker6 closed 2 years ago

cbaker6 commented 2 years ago

New Pull Request Checklist

Issue Description

Some naming in the SDK doesn't match Swift Style guide

Related issue: #n/a

Approach

Move to matching Swift Style Guide. Breaking, but the compiler should get most of these correct. Many people are probably not using most of these as they have default values...

Makes the following changes:

TODOs before merging

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

codecov[bot] commented 2 years ago

Codecov Report

Merging #321 (9b9fa43) into main (22be4df) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   84.98%   84.96%   -0.02%     
==========================================
  Files         114      114              
  Lines       12049    12049              
==========================================
- Hits        10240    10238       -2     
- Misses       1809     1811       +2     
Impacted Files Coverage Ξ”
Sources/ParseSwift/API/API+Command.swift 84.64% <100.00%> (ΓΈ)
...s/ParseSwift/Objects/ParseInstallation+async.swift 100.00% <100.00%> (ΓΈ)
...ParseSwift/Objects/ParseInstallation+combine.swift 92.94% <100.00%> (ΓΈ)
Sources/ParseSwift/Objects/ParseInstallation.swift 82.36% <100.00%> (ΓΈ)
Sources/ParseSwift/Objects/ParseObject+async.swift 100.00% <100.00%> (ΓΈ)
...urces/ParseSwift/Objects/ParseObject+combine.swift 92.94% <100.00%> (ΓΈ)
Sources/ParseSwift/Objects/ParseObject.swift 82.29% <100.00%> (ΓΈ)
Sources/ParseSwift/Objects/ParseUser+async.swift 100.00% <100.00%> (ΓΈ)
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.27% <100.00%> (ΓΈ)
Sources/ParseSwift/Objects/ParseUser.swift 82.45% <100.00%> (-0.19%) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 22be4df...9b9fa43. Read the comment docs.

cbaker6 commented 2 years ago

@pmmlo can you look at this? I'm attempting to make the method signatures more swifty

pmmlo commented 2 years ago

@pmmlo can you look at this? I'm attempting to make the method signatures more swifty

Looks great! What an annoying refactor πŸ˜΅β€πŸ’«

cbaker6 commented 2 years ago

Looks great! What an annoying refactor

I feel like these are always tricky to get right the first time. Since we have to introduce breaks in 4.0.0, might as well get them out of the way now.

I'm going to merge this one, but if you see other changes like this that should be made, can you open some PR's?

pmmlo commented 2 years ago

Looks great! What an annoying refactor

I feel like these are always tricky to get right the first time. Since we have to introduce breaks in 4.0.0, might as well get them out of the way now.

I'm going to merge this one, but if you see other changes like this that should be made, can you open some PR's?

Makes a lot of sense. Will try my best to help as I see them.

Thanks very much for another great release candidate!