cbaker6 commented 2 years ago

New Pull Request Checklist

[x] I am not disclosing a vulnerability.
[x] I am creating this PR in reference to an issue.

Issue Description

Swift 5.2 and Xcode 11 isn't supported by the AppStore anymore per Apple:

iPhone and iPad apps. Starting April 26, 2021, all iPhone and iPad apps submitted to the App Store must be built with Xcode 12 and the iOS 14 SDK or later. The iOS SDK provides access to exciting new features like App Clips, Home screen widgets, ARKit, RealityKit, and much more.

Dropping support for 5.2 allows the SDK to be designed with the latest advancements of 5.3+; particularly:

[x] availability of self (the SDK is currently designed to use self a specific way because of 5.2)
[x] key paths (the SDK is currently designed to not use keyPath's as functions because of 5.2)
[x] much more

SwiftPackageIndex has also stopped building Swift 5.2 and only builds Swift 5.3+: https://swiftpackageindex.com/parse-community/Parse-Swift/builds

Related issue: #n/a

Approach

Remove Swift 5.2 from CI along with any related compiler checks.

TODOs before merging

[x] Add entry to changelog

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

codecov[bot] commented 2 years ago

Codecov Report

Merging #356 (b421ebf) into main (2cb662a) will decrease coverage by 0.10%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   88.00%   87.90%   -0.11%     
==========================================
  Files         114      114              
  Lines       12209    12198      -11     
==========================================
- Hits        10745    10723      -22     
- Misses       1464     1475      +11

Impacted Files	Coverage Δ
Sources/ParseSwift/Extensions/Data.swift	`58.33% <ø> (-41.67%)`	:arrow_down:
Sources/ParseSwift/Objects/ParseUser+async.swift	`100.00% <ø> (ø)`
Sources/ParseSwift/Objects/ParseUser+combine.swift	`95.55% <ø> (ø)`
Sources/ParseSwift/Objects/ParseUser.swift	`86.20% <ø> (ø)`
Sources/ParseSwift/Coding/ParseEncoder.swift	`77.31% <0.00%> (-0.46%)`	:arrow_down:
Sources/ParseSwift/Objects/ParseObject.swift	`85.19% <0.00%> (+0.45%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2cb662a...b421ebf. Read the comment docs.