parse-community / Parse-Swift

The Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, Linux, Android, Windows)
https://parseplatform.org
MIT License
306 stars 69 forks source link

feat: add includeAll computed property to Query #362

Closed cbaker6 closed 2 years ago

cbaker6 commented 2 years ago

New Pull Request Checklist

Issue Description

includeAll should be a computed property since it doesn't take any arguments.

Related issue: #n/a

Approach

Add an includeAll computed property to Query and deprecate includeAll(). Improve documentation of fetch(includeKeys...) to mention use of "*" is only one level deep.

TODOs before merging

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

codecov[bot] commented 2 years ago

Codecov Report

Merging #362 (feeac54) into main (a82fd99) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   87.91%   87.94%   +0.03%     
==========================================
  Files         114      114              
  Lines       12201    12207       +6     
==========================================
+ Hits        10726    10736      +10     
+ Misses       1475     1471       -4     
Impacted Files Coverage Δ
...s/ParseSwift/Objects/ParseInstallation+async.swift 100.00% <ø> (ø)
...ParseSwift/Objects/ParseInstallation+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 85.39% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject+async.swift 100.00% <ø> (ø)
...urces/ParseSwift/Objects/ParseObject+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 85.03% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.55% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 86.20% <ø> (ø)
Sources/ParseSwift/Types/Query.swift 94.37% <100.00%> (+0.04%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a82fd99...feeac54. Read the comment docs.