Closed cbaker6 closed 2 years ago
Merging #367 (172b9be) into main (6fc9d2d) will decrease coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 87.95% 87.90% -0.05%
==========================================
Files 114 114
Lines 12213 12214 +1
==========================================
- Hits 10742 10737 -5
- Misses 1471 1477 +6
Impacted Files | Coverage Δ | |
---|---|---|
Sources/ParseSwift/API/API+Command.swift | 89.21% <100.00%> (ø) |
|
Sources/ParseSwift/Objects/ParseInstallation.swift | 85.39% <100.00%> (ø) |
|
Sources/ParseSwift/Objects/ParseUser.swift | 86.03% <100.00%> (-0.18%) |
:arrow_down: |
Sources/ParseSwift/Types/Query.swift | 94.38% <100.00%> (+<0.01%) |
:arrow_up: |
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift | 76.09% <0.00%> (-0.59%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6fc9d2d...172b9be. Read the comment docs.
New Pull Request Checklist
Issue Description
includeAll
only provides one level deep, it's currently not possible in the Swift SDK to specifyincludeAll
along with additionalinclude
keys, preventing the ability to request the server toincludeAll
one level deep and individually specify multiple level deep includesinclude
, it's currently possible to send duplicate keys to the server because theinclude
argument is an array. Though the server has a dedupe process to handle this, the client will send extra strings when this occursincludeAll
property addition and method deprecation in #362Related issue: #359
Approach
includeAll
key to be sent with additionalinclude
keys. Note that as of today, it doesn't look like the server has this feature implemented and will simplyincludeAll
instead of looking at the rest of the keysinclude
argument is specified, convert it to aSet
to prevent duplicate keys from being sent to the serverTODOs before merging