Closed cbaker6 closed 2 years ago
Merging #378 (b530234) into main (89e5e69) will increase coverage by
0.23%
. The diff coverage is98.90%
.
@@ Coverage Diff @@
## main #378 +/- ##
==========================================
+ Coverage 89.06% 89.29% +0.23%
==========================================
Files 156 157 +1
Lines 14778 14970 +192
==========================================
+ Hits 13162 13368 +206
+ Misses 1616 1602 -14
Impacted Files | Coverage Δ | |
---|---|---|
Sources/ParseSwift/Storage/ParseStorage.swift | 82.14% <ø> (ø) |
|
Sources/ParseSwift/Types/ParseACL.swift | 93.58% <ø> (ø) |
|
Sources/ParseSwift/Storage/KeychainStore.swift | 97.86% <98.40%> (+2.21%) |
:arrow_up: |
Sources/ParseSwift/Objects/ParseInstallation.swift | 85.27% <100.00%> (ø) |
|
Sources/ParseSwift/Objects/ParseObject.swift | 87.29% <100.00%> (ø) |
|
Sources/ParseSwift/Objects/ParseUser.swift | 86.34% <100.00%> (+0.19%) |
:arrow_up: |
Sources/ParseSwift/Parse.swift | 91.28% <100.00%> (+2.61%) |
:arrow_up: |
...es/ParseSwift/Protocols/ParseHookRequestable.swift | 100.00% <100.00%> (ø) |
|
Sources/ParseSwift/Types/ParseConfig.swift | 100.00% <100.00%> (+1.09%) |
:arrow_up: |
...es/ParseSwift/Types/ParseKeychainAccessGroup.swift | 100.00% <100.00%> (ø) |
|
... and 8 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
New Pull Request Checklist
Issue Description
Items in keychain currently can't be synced across apps or groups.
Related issue: #n/a
Approach
Follow Apple's guide to add an access group and enable synchronizing keychain across devices. The method below has been added:
All Keychain items can be synced except for
ParseInstallation
andParseVersion
as both of these are unique to it's respective install.TODOs before merging