Closed finestructure closed 2 years ago
Merging #383 (7339dd5) into main (3b36877) will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 89.67% 89.66% -0.02%
==========================================
Files 155 155
Lines 14121 14121
==========================================
- Hits 12663 12661 -2
- Misses 1458 1460 +2
Impacted Files | Coverage Δ | |
---|---|---|
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift | 76.16% <0.00%> (-0.59%) |
:arrow_down: |
Sources/ParseSwift/Objects/ParseUser.swift | 86.29% <0.00%> (+0.17%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3b36877...7339dd5. Read the comment docs.
Thanks Sven! Based on https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/pull/1892 do you recommend to merge this now or should I wait?
It should go in as soon as possible, as that PR (#1892) will briefly disable the documentation link until we've reprocessed. I'll manually trigger after you merge so we don't have a 24h gap!
New Pull Request Checklist
Issue Description
This corrects a mistake I made when I proposed the changes for doc generation: we don't actually generate docs for
macos-xcodebuild
! The error was masked, because once docs are in S3 they don't get deleted by subsequent builds not generating them. I.e. the existing docs formain
were simply slowly getting more and more outdated.A recent change on our end exposed this issue.
Related issue: #n/a
Approach
TODOs before merging