parse-community / Parse-Swift

The Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, Linux, Android, Windows)
https://parseplatform.org
MIT License
308 stars 69 forks source link

refactor: move open class methods from extension to class #389

Closed cbaker6 closed 2 years ago

cbaker6 commented 2 years ago

New Pull Request Checklist

Issue Description

The compiler doesn't like for Swift based open methods to be declared in extensions. More info here. When a method is open in Xcode 14, a warning is thrown by the compiler.

Related issue: #n/a

Approach

Move open methods inside their respective classes.

TODOs before merging

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

codecov[bot] commented 2 years ago

Codecov Report

Merging #389 (3e73598) into main (413e995) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
- Coverage   89.68%   89.66%   -0.03%     
==========================================
  Files         155      155              
  Lines       14121    14125       +4     
==========================================
  Hits        12665    12665              
- Misses       1456     1460       +4     
Impacted Files Coverage Δ
Sources/ParseSwift/LiveQuery/Subscription.swift 97.87% <ø> (ø)
...es/ParseSwift/LiveQuery/SubscriptionCallback.swift 70.45% <ø> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 85.46% <100.00%> (+0.06%) :arrow_up:
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 76.16% <0.00%> (-0.59%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.