parse-community / Parse-Swift

The Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, Linux, Android, Windows)
https://parseplatform.org
MIT License
308 stars 69 forks source link

fix: allow fully qualified ParseSwift types #397

Closed cbaker6 closed 2 years ago

cbaker6 commented 2 years ago

New Pull Request Checklist

Issue Description

The ParseSwift framework has public struct named ParseSwift that causes an issue when developers want to use a fully qualified ParseSwift type.

Related issue: #396

Approach

Change the ParseSwift type to Parse and make the updated type internal. This results in zero changes necessary for a user of the SDK and enables the ability to use fully qualified types when necessary. This reverts a change that was added in #54

TODOs before merging

parse-github-assistant[bot] commented 2 years ago

I will reformat the title to use the proper commit message syntax.

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

codecov[bot] commented 2 years ago

Codecov Report

Merging #397 (d514ad1) into main (a143c0f) will decrease coverage by 0.01%. The diff coverage is 91.31%.

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   89.69%   89.67%   -0.02%     
==========================================
  Files         157      158       +1     
  Lines       15072    15075       +3     
==========================================
  Hits        13519    13519              
- Misses       1553     1556       +3     
Impacted Files Coverage Δ
...s/ParseSwift/Objects/ParseInstallation+async.swift 100.00% <ø> (ø)
...ParseSwift/Objects/ParseInstallation+combine.swift 93.81% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject+async.swift 100.00% <ø> (ø)
...urces/ParseSwift/Objects/ParseObject+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 87.29% <ø> (-0.15%) :arrow_down:
Sources/ParseSwift/Objects/ParseUser+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.71% <ø> (ø)
Sources/ParseSwift/Types/ParseField.swift 100.00% <ø> (ø)
...t/Types/ParsePushPayload/ParsePushPayloadAny.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/QueryWhere.swift 100.00% <ø> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.