parse-community / Parse-Swift

The Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, Linux, Android, Windows)
https://parseplatform.org
MIT License
304 stars 69 forks source link

feat: add become installation method & fix loginUsingObjCKeychain #407

Closed cbaker6 closed 2 years ago

cbaker6 commented 2 years ago

New Pull Request Checklist

Issue Description

391 added some migration methods but they currently have some issues:

Related issue: #n/a

Approach

TODOs before merging

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

codecov[bot] commented 2 years ago

Codecov Report

Merging #407 (2dc94c7) into main (a5dbff4) will decrease coverage by 0.01%. The diff coverage is 92.38%.

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   89.94%   89.92%   -0.02%     
==========================================
  Files         158      158              
  Lines       15175    15266      +91     
==========================================
+ Hits        13649    13728      +79     
- Misses       1526     1538      +12     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseInstallation.swift 85.72% <88.88%> (+0.07%) :arrow_up:
Sources/ParseSwift/Storage/KeychainStore.swift 96.58% <92.59%> (-1.29%) :arrow_down:
...s/ParseSwift/Objects/ParseInstallation+async.swift 100.00% <100.00%> (ø)
...ParseSwift/Objects/ParseInstallation+combine.swift 94.28% <100.00%> (+0.47%) :arrow_up:
Sources/ParseSwift/Objects/ParseUser.swift 87.09% <100.00%> (-0.18%) :arrow_down:
Sources/ParseSwift/Parse.swift 99.01% <100.00%> (ø)
Sources/ParseSwift/Coding/ParseEncoder.swift 77.57% <0.00%> (-0.47%) :arrow_down:
Sources/ParseSwift/Objects/ParseObject.swift 89.45% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.