parse-community / ParseFacebookUtils-Android

A utility library to authenticate ParseUsers with the Facebook SDK
http://docs.parseplatform.org/android/guide/#facebook-users
Other
53 stars 63 forks source link

Add imprecise date format support on parse Facebook auth data. #35

Closed kazukinr closed 6 years ago

kazukinr commented 6 years ago

fix #34

Fix: ParseFacebookUtils.initialize is not completed when Facebook auth data has imprecise format date string.

codecov[bot] commented 6 years ago

Codecov Report

Merging #35 into master will increase coverage by 1.06%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
+ Coverage     57.73%   58.79%   +1.06%     
- Complexity       36       37       +1     
============================================
  Files             2        2              
  Lines           194      199       +5     
  Branches         22       22              
============================================
+ Hits            112      117       +5     
  Misses           73       73              
  Partials          9        9
Impacted Files Coverage Δ Complexity Δ
...ry/src/main/java/com/parse/FacebookController.java 76.92% <100%> (+1.34%) 16 <1> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa41adc...146a907. Read the comment docs.

rogerhu commented 6 years ago

Thanks for the contribution!

rogerhu commented 6 years ago

Please use jitpack.io and verify that the changes work for you. If so, I'm happy to release a version for you.

kazukinr commented 6 years ago

I verified using jitpack.io, but I'm sorry our problem has not been fixed by this PR. I'll keep investigating the cause of problem.

I'm sorry I couldn't fix the issue, and thanks for your support.