r21nomi commented 6 years ago

related to #34

I found another problem that authData.get(KEY_REFRESH_DATE) sometimes return null in case of login for facebook with another platform's sdk.

In my case, NPE had been thrown since authData didn't have "last_refresh_date".

So, I added null checking.

About former issue #34 , I confirmed the problem was solved by this fixing.

Thanks.

codecov[bot] commented 6 years ago

Codecov Report

Merging #36 into master will increase coverage by 0.61%. The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #36      +/-   ##
===========================================
+ Coverage     58.79%   59.4%   +0.61%     
- Complexity       37      38       +1     
===========================================
  Files             2       2              
  Lines           199     202       +3     
  Branches         22      23       +1     
===========================================
+ Hits            117     120       +3     
  Misses           73      73              
  Partials          9       9

Impacted Files	Coverage Δ	Complexity Δ
...ry/src/main/java/com/parse/FacebookController.java	`77.65% <100%> (+0.73%)`	`17 <0> (+1)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3d07cf...b393d81. Read the comment docs.

kazukinr commented 6 years ago

Thank you! I verified that the problem was solved too!

parse-community / ParseFacebookUtils-Android

Fix error parsing process for date fail because of getting null #36

Codecov Report