parse-community / ParseFacebookUtils-Android

A utility library to authenticate ParseUsers with the Facebook SDK
http://docs.parseplatform.org/android/guide/#facebook-users
Other
53 stars 63 forks source link

Pass null for newly required dataAccessExpirationTime #48

Closed Jawnnypoo closed 5 years ago

Jawnnypoo commented 5 years ago

If you look at the constructor for AccessToken:

@param dataAccessExpirationTime The time when user data access expires

and if a null value is passed:

this.dataAccessExpirationTime =
                dataAccessExpirationTime != null && dataAccessExpirationTime.getTime() != 0
                    ? dataAccessExpirationTime
                    : DEFAULT_EXPIRATION_TIME;

where DEFAULT_EXPIRATION_TIME = new Date(Long.MAX_VALUE)

This will fix https://github.com/parse-community/ParseFacebookUtils-Android/issues/46

codecov[bot] commented 5 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #48   +/-   ##
======================================
  Coverage        60%   60%           
  Complexity       38    38           
======================================
  Files             2     2           
  Lines           200   200           
  Branches         22    22           
======================================
  Hits            120   120           
  Misses           71    71           
  Partials          9     9
Impacted Files Coverage Δ Complexity Δ
...in/java/com/parse/facebook/FacebookController.java 79.34% <ø> (ø) 17 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad856ae...31428b4. Read the comment docs.