search

parse-community / ParseFacebookUtils-Android

A utility library to authenticate ParseUsers with the Facebook SDK
http://docs.parseplatform.org/android/guide/#facebook-users
Other
53 stars 63 forks source link

Support facebook-android-sdk >= 5 #51

Closed romanbsd closed 5 years ago

romanbsd commented 5 years ago

The constructor parameters for AccessToken have changed in version 5.x of the Facebook SDK.

rogerhu commented 5 years ago

Thanks! Can you fix tests too?

/home/travis/build/parse-community/ParseFacebookUtils-Android/library/src/test/java/com/parse/facebook/FacebookControllerTest.java:95: error: no suitable constructor found for AccessToken(String,String,String,Set,,,Date,,) AccessToken accessToken = new AccessToken( ^ constructor AccessToken.AccessToken(String,String,String,Collection,Collection,Collection,AccessTokenSource,Date,Date,Date) is not applicable (actual and formal argument lists differ in length) constructor AccessToken.AccessToken(Parcel) is not applicable (actual and formal argument lists differ in length) 2 errors :library:compileDebugUnitTestJavaWithJavac FAILED :library:compileDebugUnitTestJavaWithJavac (Thread[Task worker for ':',5,main]) completed. Took 2.03 secs.

romanbsd commented 5 years ago

Will do

romanbsd commented 5 years ago

Tests pass

mtrezza commented 5 years ago

@Jawnnypoo Can you please check, merge, release? I would also like to use FB SDK 5.x

Jawnnypoo commented 5 years ago

Released as 1.14.0, enjoy!

mtrezza commented 5 years ago

@romanbsd Thanks for the PR! @Jawnnypoo You are the best! Tested and works like a charm 🤙